From olivier.lahaye at cea.fr  Wed Jul 16 15:22:25 2014
From: olivier.lahaye at cea.fr (Olivier LAHAYE)
Date: Wed, 16 Jul 2014 15:22:25 +0200
Subject: [Udpcast] Patch that fix build on rhel-7 and fc-20 (fd_set problem)
Message-ID: <2374651.5xyGuGH0Wm@is222272.intra.cea.fr>


Hi,

Here is a patch to udpcast that fixes the build problem on rhel-7-x86_64 and 
fc-20-x86_64.

Please review the patch, merge it to the source-tree and provide a updated 
tarball.

Thanks in advance.

Olivier.

-- 
    Olivier Lahaye
    DRT/LIST/DIR
-------------- next part --------------
A non-text attachment was scrubbed...
Name: udpcast-fd_set.patch
Type: text/x-patch
Size: 2255 bytes
Desc: not available
URL: <http://www.udpcast.linux.lu/pipermail/udpcast/attachments/20140716/2f36f96d/attachment.bin>

From alain at knaff.lu  Wed Jul 16 15:39:00 2014
From: alain at knaff.lu (Alain Knaff)
Date: Wed, 16 Jul 2014 15:39:00 +0200
Subject: [Udpcast] Patch that fix build on rhel-7 and fc-20 (fd_set
	problem)
In-Reply-To: <2374651.5xyGuGH0Wm@is222272.intra.cea.fr>
References: <2374651.5xyGuGH0Wm@is222272.intra.cea.fr>
Message-ID: <53C68074.3040407@knaff.lu>

On 16/07/14 15:22, Olivier LAHAYE wrote:
> 
> Hi,
> 
> Here is a patch to udpcast that fixes the build problem on rhel-7-x86_64 and 
> fc-20-x86_64.
> 
> Please review the patch, merge it to the source-tree and provide a updated 
> tarball.
> 
> Thanks in advance.
> 
> Olivier.
> 

Could you maybe first start with explaining what "the" build problems on
rhel-7 and fc-20 are?

Thanks,

Alain



From mikes at kuentos.guam.net  Wed Jul 16 16:20:36 2014
From: mikes at kuentos.guam.net (Michael D. Setzer II)
Date: Thu, 17 Jul 2014 00:20:36 +1000
Subject: [Udpcast] Patch that fix build on rhel-7 and fc-20 (fd_set
	problem)
Message-ID: <53C68A34.5282.360B7@mikes.kuentos.guam.net>

I don't know about rhel-7-x86_64 but with both fc-20 32bit and 64 I get the 
following error after doing ./configure then make.


In file included from console.c:7:0:
console.h:25:9: error: unknown type name ‘fd_set’
         fd_set *read_set, struct timeval *tv,
         ^
make: *** [console.o] Error 1


My fix was to console.h to add
#include <sys/select.h>


After adding that line, and rerunning make it compiles on both the 32bit and 
64bit fedora 20 machines I have. Don't know if this patch is effecting the 
whole thing, or if this addition might cause problems building on other 
systems. Just found where fd_set was defined and added the include.








On 16 Jul 2014 at 15:39, Alain Knaff wrote:


Date sent:              Wed, 16 Jul 2014 15:39:00 +0200
From:                      Alain Knaff <alain at knaff.lu>
To:                          udpcast at udpcast.linux.lu
Subject:                  Re: [Udpcast] Patch that fix build on rhel-7 and fc-20 
(fd_set
                                 problem)


> On 16/07/14 15:22, Olivier LAHAYE wrote:
>>
> >Hi,
>>
> > Here is a patch to udpcast that fixes the build problem on
> > rhel-7-x86_64 and fc-20-x86_64.
>>
> > Please review the patch, merge it to the source-tree and provide a
> > updated tarball.
>>
> > Thanks in advance.
>>
> >Olivier.
>>
>
> Could you maybe first start with explaining what "the" build problems
> on rhel-7 and fc-20 are?
>
>Thanks,
>
>Alain
>
>_______________________________________________
> Udpcast mailing list
>Udpcast at udpcast.linux.lu
>https://www.udpcast.linux.lu/cgi-bin/mailman/listinfo/udpcast


  
+----------------------------------------------------------+
  Michael D. Setzer II -  Computer Science Instructor      
  Guam Community College  Computer Center                  
  mailto:mikes at kuentos.guam.net                            
  mailto:msetzerii at gmail.com
  http://www.guam.net/home/mikes
  Guam - Where America's Day Begins                        
  G4L Disk Imaging Project maintainer 
  http://sourceforge.net/projects/g4l/
+----------------------------------------------------------+

http://setiathome.berkeley.edu (Original)
Number of Seti Units Returned:  19,471
Processing time:  32 years, 290 days, 12 hours, 58 minutes
(Total Hours: 287,489)

BOINC at HOME CREDITS
ROSETTA     17621215.996525   |   SETI        29126476.308997
ABC         16613838.513356   |   EINSTEIN    28060690.358937




From olivier.lahaye at cea.fr  Wed Jul 16 16:36:52 2014
From: olivier.lahaye at cea.fr (Olivier LAHAYE)
Date: Wed, 16 Jul 2014 16:36:52 +0200
Subject: [Udpcast] Patch that fix build on rhel-7 and fc-20 (fd_set
	problem)
In-Reply-To: <53C68A34.5282.360B7@mikes.kuentos.guam.net>
References: <53C68A34.5282.360B7@mikes.kuentos.guam.net>
Message-ID: <1554171.82vxGPrQjD@is222272.intra.cea.fr>


My fix is fixing this exact problem listed in January in the ML.

My patch is just cleaner in the way that structures are declared in the .h file 
and that it avoids duplicate include of sys/select.h in both .c and .h

Best regards,

Olivier.

Le Thursday 17 July 2014 00:20:36 Michael D. Setzer II a écrit :
> I don't know about rhel-7-x86_64 but with both fc-20 32bit and 64 I get the
> following error after doing ./configure then make.
> 
> 
> In file included from console.c:7:0:
> console.h:25:9: error: unknown type name ‘fd_set’
>          fd_set *read_set, struct timeval *tv,
>          ^
> make: *** [console.o] Error 1
> 
> 
> My fix was to console.h to add
> #include <sys/select.h>
> 
> 
> After adding that line, and rerunning make it compiles on both the 32bit and
> 64bit fedora 20 machines I have. Don't know if this patch is effecting the
> whole thing, or if this addition might cause problems building on other
> systems. Just found where fd_set was defined and added the include.
> 
> 
> 
> 
> 
> 
> 
> 
> On 16 Jul 2014 at 15:39, Alain Knaff wrote:
> 
> 
> Date sent:              Wed, 16 Jul 2014 15:39:00 +0200
> From:                      Alain Knaff <alain at knaff.lu>
> To:                          udpcast at udpcast.linux.lu
> Subject:                  Re: [Udpcast] Patch that fix build on rhel-7 and
> fc-20 (fd_set
>                                  problem)
> 
> > On 16/07/14 15:22, Olivier LAHAYE wrote:
> > >Hi,
> > >
> > > Here is a patch to udpcast that fixes the build problem on
> > > rhel-7-x86_64 and fc-20-x86_64.
> > > 
> > > Please review the patch, merge it to the source-tree and provide a
> > > updated tarball.
> > > 
> > > Thanks in advance.
> > >
> > >Olivier.
> > 
> > Could you maybe first start with explaining what "the" build problems
> > on rhel-7 and fc-20 are?
> >
> >Thanks,
> >
> >Alain
> >
> >_______________________________________________
> >
> > Udpcast mailing list
> >
> >Udpcast at udpcast.linux.lu
> >https://www.udpcast.linux.lu/cgi-bin/mailman/listinfo/udpcast
> 
>   
> +----------------------------------------------------------+
>   Michael D. Setzer II -  Computer Science Instructor
>   Guam Community College  Computer Center
>   mailto:mikes at kuentos.guam.net
>   mailto:msetzerii at gmail.com
>   http://www.guam.net/home/mikes
>   Guam - Where America's Day Begins
>   G4L Disk Imaging Project maintainer
>   http://sourceforge.net/projects/g4l/
> +----------------------------------------------------------+
> 
> http://setiathome.berkeley.edu (Original)
> Number of Seti Units Returned:  19,471
> Processing time:  32 years, 290 days, 12 hours, 58 minutes
> (Total Hours: 287,489)
> 
> BOINC at HOME CREDITS
> ROSETTA     17621215.996525   |   SETI        29126476.308997
> ABC         16613838.513356   |   EINSTEIN    28060690.358937
> 
> 
> _______________________________________________
> Udpcast mailing list
> Udpcast at udpcast.linux.lu
> https://www.udpcast.linux.lu/cgi-bin/mailman/listinfo/udpcast


Cordialement,

Olivier.

-- 
    Olivier Lahaye
    DRT/LIST/DIR



From mikes at kuentos.guam.net  Wed Jul 16 20:00:55 2014
From: mikes at kuentos.guam.net (Michael D. Setzer II)
Date: Thu, 17 Jul 2014 04:00:55 +1000
Subject: [Udpcast] Patch that fix build on rhel-7 and fc-20 (fd_set
	problem)
In-Reply-To: <1554171.82vxGPrQjD@is222272.intra.cea.fr>
References: <53C68A34.5282.360B7@mikes.kuentos.guam.net>,
 <1554171.82vxGPrQjD@is222272.intra.cea.fr>
Message-ID: <53C6BDD7.9271.7DEF2@mikes.kuentos.guam.net>

On 16 Jul 2014 at 16:36, Olivier LAHAYE wrote:

From:           	Olivier LAHAYE <olivier.lahaye at cea.fr>
To:             	udpcast at udpcast.linux.lu
Date sent:      	Wed, 16 Jul 2014 16:36:52 +0200
Organization:   	CEA
Subject:        	Re: [Udpcast] Patch that fix build on rhel-7 and fc-20 
(fd_set
	problem)
Send reply to:  	olivier.lahaye at cea.fr
	
> 
> My fix is fixing this exact problem listed in January in the ML.
> 
> My patch is just cleaner in the way that structures are declared in
> the .h file and that it avoids duplicate include of sys/select.h in
> both .c and .h
> 

In looking close at the console.c program is that it includes the console.h 
before it includes the sys/select.h in the ifndef. Haven't used MINGW32 but a 
few times, so perhaps it doesn't use sys/select.h. So, either moving the 
include "console.h" in the ifndef after the include <sys/select.h> and including 
it in the #else part if necessary fro the MINGW32?
 

> Best regards,
> 
> Olivier.
> 
> Le Thursday 17 July 2014 00:20:36 Michael D. Setzer II a écrit : > I
> don't know about rhel-7-x86_64 but with both fc-20 32bit and 64 I get
> the > following error after doing ./configure then make. > > > In file
> included from console.c:7:0: > console.h:25:9: error: unknown type
> name ‘fd_set’ >          fd_set *read_set, struct timeval *tv, >  
>        ^ > make: *** [console.o] Error 1 > > > My fix was to console.h
> to add > #include <sys/select.h> > > > After adding that line, and
> rerunning make it compiles on both the 32bit and > 64bit fedora 20
> machines I have. Don't know if this patch is effecting the > whole
> thing, or if this addition might cause problems building on other >
> systems. Just found where fd_set was defined and added the include. >
> > > > > > > > > On 16 Jul 2014 at 15:39, Alain Knaff wrote: > > > Date
> sent:              Wed, 16 Jul 2014 15:39:00 +0200 > From:            
>          Alain Knaff <alain at knaff.lu> > To:                         
> udpcast at udpcast.linux.lu > Subject:                  Re: [Udpcast]
> Patch that fix build on rhel-7 and > fc-20 (fd_set >                  
>                problem) > > > On 16/07/14 15:22, Olivier LAHAYE wrote:
> > > >Hi, > > > > > > Here is a patch to udpcast that fixes the build
> problem on > > > rhel-7-x86_64 and fc-20-x86_64. > > > > > > Please
> review the patch, merge it to the source-tree and provide a > > >
> updated tarball. > > > > > > Thanks in advance. > > > > > >Olivier. >
> > > > Could you maybe first start with explaining what "the" build
> problems > > on rhel-7 and fc-20 are? > > > >Thanks, > > > >Alain > >
> > >_______________________________________________ > > > > Udpcast
> mailing list > > > >Udpcast at udpcast.linux.lu >
> >https://www.udpcast.linux.lu/cgi-bin/mailman/listinfo/udpcast > >   >
> +----------------------------------------------------------+ >  
> Michael D. Setzer II -  Computer Science Instructor >   Guam Community
> College  Computer Center >   mailto:mikes at kuentos.guam.net >  
> mailto:msetzerii at gmail.com >   http://www.guam.net/home/mikes >   Guam
> - Where America's Day Begins >   G4L Disk Imaging Project maintainer >
>   http://sourceforge.net/projects/g4l/ >
> +----------------------------------------------------------+ > >
> http://setiathome.berkeley.edu (Original) > Number of Seti Units
> Returned:  19,471 > Processing time:  32 years, 290 days, 12 hours, 58
> minutes > (Total Hours: 287,489) > > BOINC at HOME CREDITS > ROSETTA    
> 17621215.996525   |   SETI        29126476.308997 > ABC        
> 16613838.513356   |   EINSTEIN    28060690.358937 > > >
> _______________________________________________ > Udpcast mailing list
> > Udpcast at udpcast.linux.lu >
> https://www.udpcast.linux.lu/cgi-bin/mailman/listinfo/udpcast
> 
> 
> Cordialement,
> 
> Olivier.
> 
> -- 
>     Olivier Lahaye
>     DRT/LIST/DIR
> 
> _______________________________________________
> Udpcast mailing list
> Udpcast at udpcast.linux.lu
> https://www.udpcast.linux.lu/cgi-bin/mailman/listinfo/udpcast


+----------------------------------------------------------+
  Michael D. Setzer II -  Computer Science Instructor      
  Guam Community College  Computer Center                  
  mailto:mikes at kuentos.guam.net                            
  mailto:msetzerii at gmail.com
  http://www.guam.net/home/mikes
  Guam - Where America's Day Begins                        
  G4L Disk Imaging Project maintainer 
  http://sourceforge.net/projects/g4l/
+----------------------------------------------------------+

http://setiathome.berkeley.edu (Original)
Number of Seti Units Returned:  19,471
Processing time:  32 years, 290 days, 12 hours, 58 minutes
(Total Hours: 287,489)

BOINC at HOME CREDITS
ROSETTA     17654864.894421   |   SETI        29197796.281212
ABC         16613838.513356   |   EINSTEIN    28060690.358937